-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disentangle TrackerTrackHitFilter
from phase-0 Strip conditions and activate common alignment track refitter sequence for phase-2
#40835
Conversation
RecoTracker/FinalTrackSelectors/plugins/TrackerTrackHitFilter.cc
Outdated
Show resolved
Hide resolved
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40835/34290
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25ee14/30798/summary.html Comparison SummarySummary:
|
…k refitter and selection sequence in Phase-2. Use std::optional in for SiStripClusterInfo
50d9a99
to
0a117c6
Compare
TrackerTrackHitFilter
from phase-0 Strip conditions and activate common alignment track refitter sequence for phase-2TrackerTrackHitFilter
from phase-0 Strip conditions and activate common alignment track refitter sequence for phase-2
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40835/34340
|
Pull request #40835 was updated. @malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25ee14/30874/summary.html Comparison SummarySummary:
|
+alca
|
@cms-sw/reconstruction-l2 do you have any comment on this PR? It would be interesting to backport it, though it's already probably too late for 13.0.0. |
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The common alignment track selection and refitting sequence currently cannot run in Phase-2 setups because of missing Phase-0 SiStrip conditions. The module
TrackerTrackHitFilter
indeed requires at construction time the following conditions:As it seems that adding Phase-0 SiStrip conditions (either in GT or by dedicated
ESSource
) would be a wrong design choice, the goal of this PR is allowTrackerTrackHitFilter
to run without Phase-0 SiStrip conditions, by means of adding a new parameterisPhase2
that governs if theSiStripClusterInfo
object used inTrackerTrackHitFilter
should be constructed or not with anesConsumes
call.Please notice that I am not really happy about addition an additional ad-hoc constructor toSiStripClusterInfo
just for this purpose, that would anyway lead to runtime failure, if its method are then subsequently called. This PR is RFC for that reason.This is achieved by using
std::optional
to declare theSiStripClusterInfo
data member and construct it only if the workflow is not meant for Phase-2.PR validation:
Run the dedicated test:
cmsRun $CMSSW_BASE/src/Alignment/OfflineValidation/test/test_all_Phase2_cfg.py
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but it would probably make sense to backport down to 12.5.x to be used in the phase-2 alignment studies happening in that cycle (see PdmV JIRA ticket)